Definition of Done generator

# Definition of Done

This is the definition of done for a web product. It is intentionally short.

If an item is not on this list, it is not required. Do not add items because they sound professional. Add them because skipping them has hurt you.

## Before you open a pull request

- The change solves the stated problem - not a neighbouring problem that was more interesting.
- You can explain the change in two or three sentences. If you can't, the work is probably too big to review.
- Existing automated tests pass locally, or you have a documented reason they don't.
- You have scanned the diff for secrets, tokens, and real customer data.

## Before you merge

- At least one other person has reviewed the pull request and approved it.
- The preview deploy has been clicked through for the path you changed.

## Before you call it shipped

- It is on the branch that will go out in the next release, and it is listed in that release.
- The tech lead has accepted it against the original request - not against a reconstructed version of it.
- User-facing or interface changes are noted where the rest of the team will actually look (changelog, README, or ticket).
- You know how to undo this: revert, flag off, or migrate back. 'We'll figure it out' is not a rollback plan.

## Explicitly not required yet

- A full accessibility audit on every PR. Do add labels and keyboard access on new UI; don't block on a specialist review you don't have.
- Analytics verification. Add it when you start making product decisions from the numbers.
- Feature flags on ordinary work. Flags are for risk, experiments, and incomplete work - not for every ticket.
- A written migration review. If you start shipping irreversible data changes, add this the same week.

## How this document is allowed to change

- If something not on this list causes a real problem twice, add a line.
- If an item has been ticked for a month and has never caught anything, propose removing it.
- The tech lead owns this file. Anyone can propose a change in a pull request.
- This is not a quality aspiration. It is the contract for "done".